index.go: add omitempty to platform #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
LGTM |
vishvananda
added a commit
to vishvananda/image-spec
that referenced
this pull request
Mar 28, 2017
The spec states that platform is an optional field for the items in the image index. Pull request opencontainers#607 added omitempty to the field, but omitempty only works for types with a zero value. Because Platform is a struct, it will never be omitted. The platform field should instead be a pointer so that it can be properly omitted when it has no value. Currently, serializing an index.json without populating platform leads to something like the following: { "schemaVersion": 2, "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:d73e0d70cb05a373b5a666ba608139624d90a88d0155d2ade06a6001a27cd8d5", "size": 348, "platform": { "architecture": "", "os": "" } } ] } With the change in this patch, leaving platform as nil will cause it to be omitted as expected. Signed-off-by: Vishvananda Ishaya Abrams <vishvananda@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com