fix error valid target in image-layout #579
Conversation
In layout.md, The validated target should be image layout itself, not image index. Signed-off-by: xiekeyang <xiekeyang@huawei.com>
| @@ -134,7 +134,7 @@ The `imageLayoutVersion` value will align with the OCI Image Specification versi | |||
|
|
|||
| ### oci-layout Example | |||
|
|
|||
| ```json | |||
| ```json,title=OCI%20Layout&mediatype=oci%2Dlayout | |||
There was a problem hiding this comment.
I'd still rather have “oci-layout file” (or similar) as the title and a real media type.
There was a problem hiding this comment.
I'd still rather have “oci-layout file” (or similar) as the title and a real media type.
it likely make no much sense. Refer to manifest.md or so.
There was a problem hiding this comment.
I'd still rather have “oci-layout file” (or similar) as the title and a real media type.
it likely make no much sense. Refer to manifest.md or so.
manifest.md has title=Manifest, which makes sense, because the JSON it's titling is a manifest. Here, the JSON we're titling is an oci-layout file, so I think we want title=oci-layout%20file.
There was a problem hiding this comment.
How is mediatype=oci%2Dlayout a valid mediatype?
There was a problem hiding this comment.
@stevvooe
Sorry for late response. This is because of https://github.com/opencontainers/image-spec/blob/master/schema/spec_test.go#L70. It means that only those who have mediatype JSON key will be validated. Any arbitrary string here will not influence it to be joined to spec-test function. I use oci-layout, as to close to description in image-layout-schema.json.
If we need a nicer name here?
There was a problem hiding this comment.
I see. We should probably note somewhere that this is not a mediatype.
|
@opencontainers/image-spec-maintainers This might be ready to merged, PTAL. |
|
I'm not opposed, though |
|
oh we do! I was searching for "oci-layout" and missed LGTM |
opencontainers#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
opencontainers#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
lgtm, will let @stevvooe ack/nack tho |
|
LGTM |
|
@xiekeyang Follow this up with a note somewhere that |
|
@stevvooe got it. i would present another patch for this. |
opencontainers/image-spec#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
opencontainers/image-spec#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
opencontainers/image-spec#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
opencontainers/image-spec#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
opencontainers/image-spec#579 (comment) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
In layout.md, The validated target should be image layout itself, not only image index.
I'd like to extract and land this firstly, while #452 is in WIP.
Signed-off-by: xiekeyang xiekeyang@huawei.com