Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the omitempty in the field #558

Closed
wants to merge 1 commit into from

Conversation

zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Feb 8, 2017

Solve #557 .
@stevvooe I can't revert #410 ,because the content have changed since it was merged. So I open this PR to restore it.

Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3 zhouhao3 changed the title Revert #410 Delete the omitempty in the field Feb 8, 2017
@stevvooe
Copy link
Contributor

stevvooe commented Feb 8, 2017

Sorry, I must have been confused. Fields should generally have omitempty. The following are missing omitempty:

https://github.com/opencontainers/image-spec/blob/master/specs-go/v1/manifest.go#L20
https://github.com/opencontainers/image-spec/blob/master/specs-go/v1/manifest_list.go#L23

I am really sorry. I misread the original changes.

@zhouhao3
Copy link
Author

zhouhao3 commented Feb 8, 2017

Uh, I think I'm a bit confused.How to determine specific circumstances?

@stevvooe
Copy link
Contributor

stevvooe commented Feb 8, 2017

@q384566678 We can close this. We have omitempty on the correct fields.

Again, apologies. I got confused when discussing this earlier.

@stevvooe stevvooe closed this Feb 8, 2017
@zhouhao3 zhouhao3 deleted the test-revert branch April 5, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants