Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Standardize language for actions ((un)packing, etc.) #554

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Contributor

@wking wking commented Feb 4, 2017

To set ourselves up for more consistent discussions. This also unifies the old “Overview” and “Understanding the Specification” sections, which had a fair amount of overlap.

Fixes #467.

The specified [components](#components) MAY be manipulated with actions.

* **pack**: Create a blob from the local filesystem (or other storage).
* **unpack**: Update the local filesystem (or other storage) based on data found in a blob.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a blob -> series of tar-based blobs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a blob -> series of tar-based blobs ?

I'm using "(un)packing" more generically than that. In the examples below, I also talk about (un)packing manifest(-list)s, and in that context it is "(de)serializing into JSON, potentially just in memory".

spec.md Outdated
Translation may be **lossy** or **lossless** depending on how well the formats align.

## Publishing Images

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is talking about packing image. If the title had better to be packing image?

Publishing might be relative to distribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is talking about packing image. If the title had better to be packing image?

Done with d50a14b92980ec.

@xiekeyang
Copy link
Contributor

xiekeyang commented Feb 7, 2017

Some suggestion:

  1. desc of translate action seems a little unclear. It might need more explication (as enum the blob format).

  2. As index PR is going to be landed, if we need consider to add delete action for specific manifest object included in index? This might be done in follow PR.

  3. Actions might need include download or fetch. The fetch tool might be landed in OCI or external project. But I think it should be implied as one kind of action in image-spec.

To set ourselves up for more consistent discussions.  This also
unifies the old "Overview" and "Understanding the Specification"
sections, which had a fair amount of overlap.

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking
Copy link
Contributor Author

wking commented Feb 7, 2017 via email

@RobDolinMS
Copy link
Collaborator

Is this intended for milestone==v1.0.0 or milestone==post-v1.0.0 ?

@wking
Copy link
Contributor Author

wking commented Apr 13, 2017 via email

@vbatts
Copy link
Member

vbatts commented May 25, 2017

I think this PR is not clarifying the semantics around image-related actions. I'm inclined to close this and we can revisit this after 1.0

@vbatts vbatts closed this May 25, 2017
@wking
Copy link
Contributor Author

wking commented May 25, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants