bugfix: walk function exit incorrectly #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, maybe the ci test is some insufficient. We had better to improve the ci test (maybe circleci is nice) , to make sure being able to check the main functionalities. |
| case nil: | ||
| return nil, fmt.Errorf("%s: config not found", cpath) | ||
| case errEOW: | ||
| // found, continue below |
|
two small comments then lgtm |
|
@jonboulle modified. PTAL, thanks. |
Signed-off-by: xiekeyang <xiekeyang@huawei.com>
|
LGTM |
|
On Wed, Aug 31, 2016 at 04:21:21AM -0700, xiekeyang wrote:
Some thoughts on testing here 1. I'm happy to write up integration |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry it is my previous fault by #201 .
That patch leads the walk function exit incorrectly.
it is because that function
filepatch.Walk()must not return error when meeting path mismatch error. Instead it should return nil. And the checking should be done in the end of walk.Here I fix the bug in this patch. I retrieve old assertion block. I've run
create,validateandunpackcommand according to the command manual successfully.I will improve the mechanism gracefully.
PTAL, Thanks lots!
Signed-off-by: xiekeyang xiekeyang@huawei.com