serialization: remove extra "hierarchy" from mediatypes #212
Conversation
| "size": 7023, | ||
| "digest": "sha256:5b0bcabd1ed22e9fb1310cf6c2dec7cdef19f0ad69efa1f392e94a4333501270" | ||
| }, | ||
| "layers": [ | ||
| { | ||
| "mediaType": "application/vnd.oci.image.serialization.rootfs.tar.gzip", | ||
| "mediaType": "application/vnd.oci.image.layer.tar+gzip", |
There was a problem hiding this comment.
It looks like the +{suffix} format is from RFC 6839. That doesn't have any examples of nested formats, but it doesn't specify a formal syntax for suffixes either. Since the layer idea doesn't seem particularly tied to tar or gzip, I'd rather use application/vnd.oci.image.layer+tar+gzip to make it easy to also support +zip or +tar+xz, etc.
There was a problem hiding this comment.
Or just +tar (with no compression, see here).
|
OHMAN GPG SIGNED COMMIT |
|
While i'm not terribly opposed, I'm not sure what harm or confusion having the name stay is? |
|
@vbatts I'd like to see cruft remove, if we can. It would be great to get an LGTM here |
|
On the call no one really objected to making this change on the call. Saving a few bytes isn't a huge deal in json land but I don't object. LGTM |
stevvooe
force-pushed
the
remove-serialization-from-mediatype
branch
from
432c134
to
dd8eaff
Compare
The fact that we are serializing is implied. This PR removes the extra bits in the media type that only serve to confuse and waste bytes. The new media types better reflect the reality for the usage of each type and how they relate. This must be followed up by a split of the serialization document, but this change _should_ be applied first. This change is backwards incompatible with previous versions of the OCI specification. Since we are before 1.0, this is acceptable. Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
remove-serialization-from-mediatype
branch
from
dd8eaff
to
5861fdb
Compare
|
LGTM |
1 similar comment
|
LGTM |
The fact that we are serializing is implied. This PR removes the extra
bits in the media type that only serve to confuse and waste bytes. The
new media types better reflect the reality for the usage of each type
and how they relate.
This must be followed up by a split of the serialization document, but
this change should be applied first.
This change is backwards incompatible with previous versions of the OCI
specification. Since we are before 1.0, this is acceptable.
Signed-off-by: Stephen J Day stephen.day@docker.com
Related to #206.