Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc: issue with displaying images #70

Closed
vbatts opened this issue May 7, 2016 · 2 comments
Closed

pandoc: issue with displaying images #70

vbatts opened this issue May 7, 2016 · 2 comments
Assignees
Milestone

Comments

@vbatts
Copy link
Member

vbatts commented May 7, 2016

with https://github.com/opencontainers/image-spec/releases/tag/v0.1.0
The media-types.png caused issues in the make docs target. See #66 (comment)

As a make-shift effort, I switched it to inline html. While that caused pandoc to not fail, it did not render the image in the resulting document.
Here's the diff that let pandoc run successfully.

diff --git a/media-types.md b/media-types.md
index 3bf7221..de6cc3b 100644
--- a/media-types.md
+++ b/media-types.md
@@ -46,6 +46,6 @@ This section shows where the OCI Image Specification is compatible with formats

 The following figure shows how the above media types reference each other:

-![Media Types](media-types.png)
+<img src="media-types.png" alt="Media Types"/>

 A reference is defined as the target content digest, as defined by the [Registry V2 HTTP API Specificiation](https://docs.docker.com/registry/spec/api/#digest-parameter). The manifest list being a "fat manifest" references one or more image manifests per target platform. An image manifest references exactly one target configuration and possibly many layers.

Other option would be a full base64 inline of the image, in an html tag. 😛

@philips
Copy link
Contributor

philips commented May 7, 2016

sounds like base64 it is! :)

On Sat, May 7, 2016 at 11:24 AM Vincent Batts notifications@github.com
wrote:

with https://github.com/opencontainers/image-spec/releases/tag/v0.1.0
The media-types.png caused issues in the make docs target. See #66
(comment)
#66 (comment)

As a make-shift effort, I switched it to inline html. While that caused
pandoc to not fail, it did not render the image in the resulting document.
Here's the diff that let pandoc run successfully.

diff --git a/media-types.md b/media-types.md
index 3bf7221..de6cc3b 100644--- a/media-types.md+++ b/media-types.md@@ -46,6 +46,6 @@ This section shows where the OCI Image Specification is compatible with formats

The following figure shows how the above media types reference each other:
-Media Types+Media Types

A reference is defined as the target content digest, as defined by the Registry V2 HTTP API Specificiation. The manifest list being a "fat manifest" references one or more image manifests per target platform. An image manifest references exactly one target configuration and possibly many layers.

Other option would be a full base64 inline of the image, in an html tag.
😛


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#70

@philips
Copy link
Contributor

philips commented May 24, 2016

This is fixed now. Closing.

@philips philips closed this as completed May 24, 2016
@philips philips added this to the v0.2.0 milestone May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants