Add unit test for validating customized media type

Signed-off-by: xiekeyang <xiekeyang@huawei.com>
opencontainers · Nov 29, 2016 · d898abe · d898abe
1 parent 21ef4e8
commit d898abe
Show file tree

Hide file tree

Showing 2 changed files with 171 additions and 1 deletion.
diff --git a/schema/manifest_test.go b/schema/manifest_test.go
@@ -21,7 +21,7 @@ import (
 	"github.com/opencontainers/image-spec/schema"
 )
 
-func TestManifest(t *testing.T) {
+func TestManifestSchema(t *testing.T) {
 	for i, tt := range []struct {
 		manifest string
 		fail     bool
@@ -151,3 +151,90 @@ func TestManifest(t *testing.T) {
 		}
 	}
 }
+
+func TestManifestCustomized(t *testing.T) {
+	for i, tt := range []struct {
+		manifest string
+		funcs    []schema.ValidateFunc
+		fail     bool
+	}{
+		// valid manifest accepts customized config media types
+		{
+			manifest: `
+{
+  "schemaVersion": 2,
+  "mediaType": "application/vnd.oci.image.manifest.v1+json",
+  "config": {
+    "mediaType": "application/vnd.customized.config+json",
+    "size": 1470,
+    "digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
+  },
+  "layers": [
+    {
+      "mediaType": "application/vnd.customized.layer.tar+gzip",
+      "size": 148,
+      "digest": "sha256:c57089565e894899735d458f0fd4bb17a0f1e0df8d72da392b85c9b35ee777cd"
+    }
+  ]
+}
+`,
+			funcs: []schema.ValidateFunc{schema.ValidateSchema},
+			fail:  false,
+		},
+
+		// expected failure strictly: unknown config.mediaType
+		{
+			manifest: `
+{
+  "schemaVersion": 2,
+  "mediaType": "application/vnd.oci.image.manifest.v1+json",
+  "config": {
+    "mediaType": "application/vnd.customized.config+json",
+    "size": 1470,
+    "digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
+  },
+  "layers": [
+    {
+      "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
+      "size": 148,
+      "digest": "sha256:c57089565e894899735d458f0fd4bb17a0f1e0df8d72da392b85c9b35ee777cd"
+    }
+  ]
+}
+`,
+			funcs: []schema.ValidateFunc{schema.ValidateSchema, schema.ValidateRefMedia},
+			fail:  true,
+		},
+
+		// expected failure strictly: unknown layers[].mediaType
+		{
+			manifest: `
+{
+  "schemaVersion": 2,
+  "mediaType": "application/vnd.oci.image.manifest.v1+json",
+  "config": {
+    "mediaType": "application/vnd.oci.image.config.v1+json",
+    "size": 1470,
+    "digest": "sha256:c86f7763873b6c0aae22d963bab59b4f5debbed6685761b5951584f6efb0633b"
+  },
+  "layers": [
+    {
+      "mediaType": "application/vnd.customized.layer.tar+gzip",
+      "size": 148,
+      "digest": "sha256:c57089565e894899735d458f0fd4bb17a0f1e0df8d72da392b85c9b35ee777cd"
+    }
+  ]
+}
+`,
+			funcs: []schema.ValidateFunc{schema.ValidateSchema, schema.ValidateRefMedia},
+			fail:  true,
+		},
+	} {
+		r := strings.NewReader(tt.manifest)
+		err := schema.MediaTypeManifest.Validate(r, tt.funcs)
+
+		if got := err != nil; tt.fail != got {
+			t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)
+		}
+	}
+}
diff --git a/schema/manifestlist_test.go b/schema/manifestlist_test.go
@@ -0,0 +1,83 @@
+// Copyright 2016 The Linux Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package schema_test
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/opencontainers/image-spec/schema"
+)
+
+func TestManifestListCustomized(t *testing.T) {
+	for i, tt := range []struct {
+		manifestList string
+		funcs        []schema.ValidateFunc
+		fail         bool
+	}{
+		// valid manifest list accepting customized media types
+		{
+			manifestList: `
+{
+  "schemaVersion": 2,
+  "mediaType": "application/vnd.oci.image.manifest.list.v1+json",
+  "manifests": [
+    {
+      "mediaType": "application/customized+json",
+      "size": 7143,
+      "digest": "sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f",
+      "platform": {
+        "architecture": "ppc64le",
+        "os": "linux"
+      }
+    }
+  ]
+}
+`,
+			funcs: []schema.ValidateFunc{schema.ValidateSchema},
+			fail:  false,
+		},
+
+		// expected failure strictly: manifests[].mediaType is unknown
+		{
+			manifestList: `
+{
+  "schemaVersion": 2,
+  "mediaType": "application/vnd.oci.image.manifest.list.v1+json",
+  "manifests": [
+    {
+      "mediaType": "application/customized+json",
+      "size": 7143,
+      "digest": "sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f",
+      "platform": {
+        "architecture": "ppc64le",
+        "os": "linux"
+      }
+    }
+  ]
+}
+`,
+			funcs: []schema.ValidateFunc{schema.ValidateSchema, schema.ValidateRefMedia},
+			fail:  true,
+		},
+	} {
+		r := strings.NewReader(tt.manifestList)
+		err := schema.MediaTypeManifestList.Validate(r, tt.funcs)
+
+		if got := err != nil; tt.fail != got {
+			t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)
+		}
+	}
+}