Remove the need to create an object id for vlan in creating a sub port router interface #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace, but only feed a vlan id tag Signed-off-by: Wenda Ni <wenni@microsoft.com>
prsunny
approved these changes
Aug 12, 2019
itaibaz
suggested changes
Aug 15, 2019
There was a problem hiding this comment.
This change does not look to be backward compatible, as it requires porting existing code that creates a RIF sub port to change, instead of using attr_vlan_id, to use attr_outer_vlan_id
while the change itself is ok, i am concerned about the loss of backward compatibility we always require
lguohan
approved these changes
Aug 15, 2019
|
I assume SONiC is the only user of SAI. If this is the case, it should be fine to make this correction as we are still at the high-level design phase to have the sub port interface feature in SONiC. |
|
@itaibaz , previous spec is a bug, we cannot keep backward compatible when fixing a bug. |
itaibaz
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we only provide the vlan id value
Signed-off-by: Wenda Ni wenni@microsoft.com