Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saiexperimentalbmtor] Update API #913

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

marian-pritsak
Copy link
Contributor

Rename APIs to bitmap_classification_table and bitmap_router

Match on ingress rif

Rename action to_tunnel -> to_nexthop

Use in_rif metadata as a bitvector

Signed-off-by: Marian Pritsak marianp@mellanox.com

Rename APIs to bitmap_classification_table and bitmap_router

Match on ingress rif

Rename action to_tunnel -> to_nexthop

Use in_rif metadata as a bitvector

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
@kcudnik
Copy link
Collaborator

kcudnik commented Jan 28, 2019

ERROR: SAI_OBJECT_TYPE_TABLE_VNET_ENTRY is not defined in OBJTOAPIMAP, missing sai_XXX_api_t declaration?
ERROR: SAI_OBJECT_TYPE_TABLE_TUNNEL_ROUTE_ENTRY is not defined in OBJTOAPIMAP, missing sai_XXX_api_t declaration?

seems like metadata is not picking up object types from sai_bmtor_api_t, let me take a look whats going on

Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
@kcudnik
Copy link
Collaborator

kcudnik commented Jan 28, 2019

ah yes, you changed object names, then it works, just you have to add LPM to acronyms list

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 28, 2019

WARN: experimental object SAI_OBJECT_TYPE_TABLE_BITMAP_CLASSIFICATION_ENTRY not present on any object list (eg. VLAN_MEMBER is present on SAI_VLAN_ATTR_MEMBER_LIST)
WARN: experimental object SAI_OBJECT_TYPE_TABLE_BITMAP_ROUTER_ENTRY not present on any object list (eg. VLAN_MEMBER is present on SAI_VLAN_ATTR_MEMBER_LIST)

consider adding iterator attributes for SAI_OBJECT_TYPE_TABLE_BITMAP_CLASSIFICATION_ENTRY and SAI_OBJECT_TYPE_TABLE_BITMAP_ROUTER_ENTRY

for SAI_OBJECT_TYPE_TABLE_BITMAP_CLASSIFICATION_ENTRY there should be attribute in router_interface object, like "classification_entries" readonly that will return all clasificaiton entries for this router_interaface

for TABLE_BITMAP_ROUTER_ENTRY i think you could skip, since many object could be set on that

@lguohan lguohan merged commit 6ad3382 into opencomputeproject:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants