Add SAI_SWITCH_ATTR_CURRENT_TEMP to get average temperature from sensors #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
reviewed
Oct 21, 2018
inc/saiswitch.h
Outdated
| @@ -409,6 +409,17 @@ typedef enum _sai_switch_attr_t | |||
| */ | |||
| SAI_SWITCH_ATTR_MAX_TEMP, | |||
|
|
|||
| /** | |||
| * @brief The average value of the temperature | |||
| * retrieved from the switch sensors | |||
There was a problem hiding this comment.
does this mean from all available sensors? not sure if description is good enough, if you have 1 sensor with 10 degree, and 2nd with 100 then average is 55 which maybe ok but system is defenetly not ok at 100
There was a problem hiding this comment.
Yes, assuming ASIC has N internal sensors, we wanted the average of the N sensors. I can update the description. This attribute is meant to be interpreted in conjunction with the MAX_TEMP to check for deviation / discard outliers (so there are no false alarms). Alternatively, we can get the list of N values (instead of just MAX_TEMP & CURRENT_TEMP) and let the application interpret ?
There was a problem hiding this comment.
updating description should be fine
|
Yes, assuming ASIC has N internal sensors, we wanted the average of the N sensors. I can update the description. This attribute is meant to be interpreted in conjunction with the MAX_TEMP to check for deviation / discard outliers (so there are no false alarms). Alternatively, we can get the list of N values (instead of just MAX_TEMP & CURRENT_TEMP) and let the application interpret ?
From: Kamil Cudnik <notifications@github.com>
Sent: Sunday, October 21, 2018 1:14 PM
To: opencomputeproject/SAI
Cc: N, Padmanabhan; Author
Subject: Re: [opencomputeproject/SAI] Add SAI_SWITCH_ATTR_CURRENT_TEMP to get average temperature from sensors (#880)
[EXTERNAL EMAIL]
Please report any suspicious attachments, links, or requests for sensitive information.
@kcudnik commented on this pull request.
________________________________
In inc/saiswitch.h<#880 (comment)>:
@@ -409,6 +409,17 @@ typedef enum _sai_switch_attr_t
*/
SAI_SWITCH_ATTR_MAX_TEMP,
+ /**
+ * @brief The average value of the temperature
+ * retrieved from the switch sensors
does this mean from all available sensors? not sure if description is good enough, if you have 1 sensor with 10 degree, and 2nd with 100 then average is 55 which maybe ok but system is defenetly not ok at 100
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#880 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AcaNoAYMg85GNtkcqoY4OPKfDYAVGK-Mks5unNVtgaJpZM4XyFKU>.
|
kcudnik
approved these changes
Oct 24, 2018
|
As suggested in the review meeting:
|
lguohan
approved these changes
Nov 8, 2018
tushar-ty
approved these changes
Nov 8, 2018
SathishKumarTR-Dell
approved these changes
Nov 8, 2018
This was referenced Nov 17, 2018
jleveque
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 4, 2021
**What I did** 1) ASICs have multiple internal thermal sensors. 2) With the help of configuration, a poller is introduced in Orchagent that will periodically retrieve values of these sensors with the help of SAI APIs (opencomputeproject/SAI#880). 3) These retrieved values are being populated to the state DB (In "ASIC_TEMPERATURE_INFO" table). **Why I did it** As part of ASIC Thermal Monitoring HLD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the average of sensors value readings from the ASIC.