Add attribute bridge id for router interface of type SAI_ROUTER_INTERFACE_TYPE_BRIDGE #868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the bridge id attribute for router interface of type SAI_ROUTER_INTERFACE_TYPE_BRIDGE. This is similar to VLAN id which is needed when the router interface is of type SAI_ROUTER_INTERFACE_TYPE_VLAN.
Motivation for this pull request:
a) A bridge router interface can be connected only to one bridge. Adding bridge id
attribute in bridge router interface would ensure that a bridge router interface can be
connected only one bridge. If this attribute is not present, the bridge router interface can be
connected to multiple bridges which is invalid.
b) All the router interfaces type have a key which need to be given during creation.
Example: For VLAN router interface, VLAN object ID is the key.
For Port router interface, Port/LAG object ID is the key.
However for bridge router interface, currently there is no key. So
bridge id is added as a key attribute for bridge router interface.
This makes creation of all router interface types consistent.