Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute bridge id for router interface of type SAI_ROUTER_INTERFACE_TYPE_BRIDGE #868

Conversation

karthik-krishnamurthy
Copy link
Contributor

@karthik-krishnamurthy karthik-krishnamurthy commented Aug 31, 2018

This pull request adds the bridge id attribute for router interface of type SAI_ROUTER_INTERFACE_TYPE_BRIDGE. This is similar to VLAN id which is needed when the router interface is of type SAI_ROUTER_INTERFACE_TYPE_VLAN.

Motivation for this pull request:

a) A bridge router interface can be connected only to one bridge. Adding bridge id
attribute in bridge router interface would ensure that a bridge router interface can be
connected only one bridge. If this attribute is not present, the bridge router interface can be
connected to multiple bridges which is invalid.

b) All the router interfaces type have a key which need to be given during creation.
Example: For VLAN router interface, VLAN object ID is the key.
For Port router interface, Port/LAG object ID is the key.
However for bridge router interface, currently there is no key. So
bridge id is added as a key attribute for bridge router interface.
This makes creation of all router interface types consistent.

@karthik-krishnamurthy
Copy link
Contributor Author

As discussed in the OCP weekly call, added the motivation behind the pull request in the description

@rameshsanth
Copy link

New enum should be added at the end. Adding them in the middle will break backward compatibility.

Copy link
Collaborator

@itaibaz itaibaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Matty, fine with Mellanox

@lguohan lguohan merged commit 55ccf88 into opencomputeproject:master Nov 1, 2018
@karthik-krishnamurthy karthik-krishnamurthy deleted the router_intf_attr_bridge_id branch November 3, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants