Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom docker repo support #24

Merged

Conversation

lukaszgyg
Copy link
Contributor

Add the custom docker repository support. This will all the custom repository configuration which is for many organisation single source of images.

@lukaszgyg lukaszgyg force-pushed the add-custom-docker-repo-support branch from 4b0787e to 1902206 Compare July 14, 2023 18:12
@lukaszgyg lukaszgyg marked this pull request as ready for review July 14, 2023 18:12
@lukaszgyg lukaszgyg force-pushed the add-custom-docker-repo-support branch from 1902206 to e700903 Compare July 14, 2023 18:14
@dbanty
Copy link
Contributor

dbanty commented Jul 14, 2023

Should we make the entire image overridable? In case the image is named differently in the custom repository or folks are using a custom fork?

@lukaszgyg
Copy link
Contributor Author

Should we make the entire image overridable? In case the image is named differently in the custom repository or folks are using a custom fork?

Yes, that is a good suggestion. It is not a case in our organisation, but I can imagine such a case.

@dbanty dbanty merged commit 2a2f8a9 into openapi-generators:v1 Jul 14, 2023
9 checks passed
@lukaszgyg lukaszgyg deleted the add-custom-docker-repo-support branch July 14, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants