Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First draft of RNG and XML #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

First draft of RNG and XML #19

wants to merge 3 commits into from

Conversation

tomschr
Copy link
Contributor

@tomschr tomschr commented Dec 7, 2017

See #18

@tomschr tomschr requested a review from a user December 7, 2017 13:41
ghost
ghost reviewed Dec 7, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good overall!, though see my two comments. And I have two additional comments:

  • do we need the RNG in addition to the RNC? if not, we could just keep the RNC.
  • maybe config.xml should be named config-example.xml

rng/config.xml Outdated
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="file:/local/repos/GH/sknorr/dietrich/rng/conversion.rnc" type="application/relax-ng-compact-syntax"?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you shouldn't commit that line. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! 👍

rng/config.xml Outdated
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="file:/local/repos/GH/sknorr/dietrich/rng/conversion.rnc" type="application/relax-ng-compact-syntax"?>
<config version="1.0">
<property key="STLYEROOT" value="/usr/share/xml/docbook/stylesheet/suse2013"/>
Copy link

@ghost ghost Dec 7, 2017 •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using a style more like <styleroot>/usr/...</styleroot> for all the properties would make this easier to validate imo. (e.g. see your STLYEROOT typo above that we can't catch currently)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tomschr