Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mobile instrumentation to log-event semantic conventions #67

Merged
merged 53 commits into from
Oct 20, 2023

Conversation

bryce-b
Copy link
Member

@bryce-b bryce-b commented May 31, 2023

Adding this semantic convention for mobile events.

@bryce-b
Copy link
Member Author

bryce-b commented May 31, 2023

@scheler

@bryce-b bryce-b closed this May 31, 2023
@bryce-b bryce-b reopened this May 31, 2023
@bryce-b bryce-b marked this pull request as ready for review May 31, 2023 21:28
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've landed at a good first pass for this lifecycle event. Thanks for sticking it out and collaborating!

@LikeTheSalad looks like the PR needs a markdown lint run.

In your example, if you want to find out a crash happened after ON_PAUSE but before ON_STOP, it's probably better to log that as a breadcrumb trail of events on a Span that happens before a crash event. Plus you'll want the lifecycle owner name to do that kind of debugging, which isn't captured in the app state.

Just wanted to point out that this is essentially what we are currently doing in the Splunk android sdk -- we put Activity state change events as span events on the "active" span for each activity..

@bidetofevil
Copy link

Just wanted to point out that this is essentially what we are currently doing in the Splunk android sdk -- we put Activity state change events as span events on the "active" span for each activity..

So during the last Client SIG, folks were saying that the current direction is to model a session not using a container Span, but as an attribute set on the particular signal (implementation details to be decided). Is this something you're thinking of following for the Splunk/Android-Extension, @breedx-splk?

@bryce-b bryce-b requested a review from a team July 7, 2023 17:02
@breedx-splk
Copy link
Contributor

So during the last Client SIG, folks were saying that the current direction is to model a session not using a container Span, but as an attribute set on the particular signal (implementation details to be decided). Is this something you're thinking of following for the Splunk/Android-Extension, @breedx-splk?

Yes, I think android instrumentation will want to keep its telemetry looking like the spec has decided and what will hopefully one day soon match with web and ios. If the attribute gets decided, then we will go that route. In the splunk distro, we will probably need to maintain the use of zipkin spans in the short term until we can coordinate with our internal teams.

@breedx-splk
Copy link
Contributor

@bryce-b Looks like a rebase is needed. Thx!

Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM content wise.

A few things regarding the structure of that:

  • Instead of writing the tables in the markdown manually let's define the attributes in a yaml file in the model directory. And then use make table-generation to generate the markdown tables in this file.
  • since this PR introduces a new semantic conventions area (i.e. directory under docs), we need a README.md file in here (see other domain directories for comparison).

@bryce-b
Copy link
Member Author

bryce-b commented Jul 26, 2023

@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers @tigrannajaryan
This PR is ready for your review

@bryce-b bryce-b requested a review from a team August 8, 2023 19:56
@tigrannajaryan
Copy link
Member

The PR contains a bunch of unrelated changes/commits. Please clean it up to make it reviewable.

bryce-b and others added 12 commits October 10, 2023 12:22
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@bryce-b bryce-b requested a review from a team October 17, 2023 17:20
@breedx-splk
Copy link
Contributor

@open-telemetry/specs-semconv-maintainers we have 4 approvals and the build is passing. Any reason not to merge?

@AlexanderWert AlexanderWert merged commit e029787 into open-telemetry:main Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experts needed This issue or pull request is outside an area where general approvers feel they can approve
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.