Add a warning to the system semantic conventions #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
add-system-conv-warning
branch
7 times, most recently
from
59ea77b
to
b39ae1e
Compare
mx-psi
approved these changes
Dec 5, 2023
ChrsMark
reviewed
Dec 5, 2023
dmitryax
force-pushed
the
add-system-conv-warning
branch
from
b39ae1e
to
84df240
Compare
3 tasks
trask
reviewed
Dec 5, 2023
joaopgrassi
approved these changes
Dec 6, 2023
|
The test is fixed in #583 |
dmitryax
force-pushed
the
add-system-conv-warning
branch
2 times, most recently
from
3e13b40
to
03321aa
Compare
trask
approved these changes
Dec 7, 2023
Add a warning the system semantic conventions to prevent implementations from adopting the breaking changes until the conventions are stabilized. This warning is to be updated once open-telemetry#246 is closed
dmitryax
force-pushed
the
add-system-conv-warning
branch
from
03321aa
to
0b049ce
Compare
|
As discussed in the SIG meeting today, I changed the URLs to absolute paths instead of relative GitHub links. Otherwise, the relative GitHub links to another version cc @jsuereth |
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning to the system semantic conventions to prevent implementations from adopting the breaking changes until the conventions are stabilized. This warning is to be updated once #246 is closed.
As discussed in the last system conventions meeting.
cc @jsuereth @open-telemetry/semconv-system-approvers
Merge requirement checklist