Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate exception attributes to registry #574

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Migrate exception attributes to registry #574

merged 7 commits into from
Dec 14, 2023

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Dec 1, 2023 •
edited
Loading

Changes

  • Move exception attributes into the registry

This is in preparation of stabilizing the exception attributes in concert with the specification. See (open-telemetry/opentelemetry-specification#3769)

Merge requirement checklist

@jsuereth jsuereth requested review from a team December 1, 2023 15:50
arminru
arminru approved these changes Dec 4, 2023
View reviewed changes
model/registry/exception.yaml Outdated Show resolved Hide resolved
jsuereth and others added 2 commits December 4, 2023 16:58
@jsuereth @arminru
Update model/registry/exception.yaml
368f9d6 
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
@jsuereth
Regenerate tables.
bacbd75
@jsuereth jsuereth merged commit 165dae5 into open-telemetry:main Dec 14, 2023
9 checks passed
@jsuereth jsuereth deleted the wip-stabilize-exceptions branch December 14, 2023 17:10
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
@jsuereth @arminru @pyohannes
Migrate exception attributes to registry (open-telemetry#574)
7a5a6b8 
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisch-me trisch-me trisch-me approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@lmolkova lmolkova lmolkova approved these changes

@cijothomas cijothomas cijothomas approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@arminru arminru arminru approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsuereth @carlosalberto @lmolkova @cijothomas @joaopgrassi @arminru @trisch-me