.NET runtime process resource attributes #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gregkalapos
reviewed
Nov 27, 2023
Kielek
commented
Nov 27, 2023
joaopgrassi
approved these changes
Nov 27, 2023
gregkalapos
approved these changes
Nov 27, 2023
pyohannes
reviewed
Nov 28, 2023
|
/cc @noahfalk could you please take a look? |
pyohannes
approved these changes
Dec 1, 2023
|
Implementation PR is merged, nuget package released as OpenTelemetry.ResourceDetectors.ProcessRuntime. Changes in semantic convention reflects implementation. If you are fine with wording it is ready to be merged. |
AlexanderWert
approved these changes
Dec 4, 2023
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-dotnet#1281
Changes
Defines what values should be set to
process.runtime.*attributes for .NET.Implementation can be found in open-telemetry/opentelemetry-dotnet-contrib#1449
Merge requirement checklist
[ ] schema-next.yaml updated with changes to existing conventions.N/A?