Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading pluralization wording related to count metrics #488

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Remove misleading pluralization wording related to count metrics #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45c7827
Fix pluralization wording related to count metrics
trask Nov 2, 2023
be56879
Update CHANGELOG.md
trask Nov 15, 2023
a318ce3
Merge remote-tracking branch 'upstream/main' into fix-pluralization-g…
trask Nov 15, 2023
c4d7f03
Merge branch 'main' into fix-pluralization-guidance
AlexanderWert Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ release.

### Fixes

- Remove misleading pluralization wording related to count metrics
([#488](https://github.com/open-telemetry/semantic-conventions/pull/488))

## v1.23.0 (2023-11-03)

This release marks the first where the core of HTTP semantic conventions have
Expand Down
6 changes: 2 additions & 4 deletions docs/general/metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,10 @@ should be pluralized, even if only a single data point is recorded.

If the value being recorded represents the count of concepts signified
by the namespace then the metric should be named `count` (within its namespace).
The pluralization rule does not apply in this case.

For example if we have a namespace `system.processes` which contains all metrics related
For example if we have a namespace `system.process` which contains all metrics related
to the processes then to represent the count of the processes we can have a metric named
`system.processes.count`. The suffix `count` here indicates that it is the count of
`system.processes`.
`system.process.count`.

#### Do not use `total`

Expand Down
Loading