Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require two approvals from different companies before merging the PR #364

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Require two approvals from different companies before merging the PR #364

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b8425f
Require two approvals from different companies before merging the PR
reyang Oct 3, 2023
2c68e59
Merge branch 'main' into reyang/pr-merge-criteria
reyang Oct 4, 2023
056ba8f
Update CONTRIBUTING.md
reyang Oct 4, 2023
1463f26
Merge branch 'main' into reyang/pr-merge-criteria
reyang Oct 5, 2023
8c1e5af
Merge branch 'main' into reyang/pr-merge-criteria
AlexanderWert Oct 7, 2023
d574518
Merge branch 'main' into reyang/pr-merge-criteria
AlexanderWert Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,23 @@ To quickly fix typos, use
make misspell-correction
```

### How to get your PR merged

A PR (pull request) is considered to be **ready to merge** when:

* It has received more than two approvals from the [code
AlexanderWert marked this conversation as resolved.
Show resolved Hide resolved
reyang marked this conversation as resolved.
Show resolved Hide resolved
owners](./.github/CODEOWNERS) (if approvals are from only one company, they
won't count).
* There is no `request changes` from the [code owners](./.github/CODEOWNERS).
* It has been at least two working days since the last modification (except for
the trivial updates, such like typo, cosmetic, rebase, etc.). This gives
people reasonable time to review.
* Trivial changes (typos, cosmetic changes, CI improvements, etc.) don't have to
wait for two days.

Any [maintainer](./README.md#contributing) can merge the PR once it is **ready
to merge**.

## Updating the referenced specification version

1. Open the `./internal/tools/update_specification_version.sh` script.
Expand Down
Loading