Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Documentation For Change in Behaviour of Reading X-Ray Tracing Info From Lambda #27

Merged
merged 10 commits into from
May 25, 2023
Merged

Updated Documentation For Change in Behaviour of Reading X-Ray Tracing Info From Lambda #27

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbd570a
updated spec following implementation of reading trace info from syst…
jdoherty May 15, 2023
4ee468b
updated following comments from Tyler
jdoherty May 16, 2023
33edcfa
Merge branch 'open-telemetry:main' into main
jdoherty May 16, 2023
bf759c0
Update specification/trace/semantic_conventions/instrumentation/aws-l…
jdoherty May 17, 2023
d1f5d6e
Merge branch 'main' into main
jdoherty May 17, 2023
ec3aecb
Merge branch 'open-telemetry:main' into main
jdoherty May 22, 2023
b1a0010
removing trailing whitespace
jdoherty May 22, 2023
22e32e3
updated changelog
jdoherty May 23, 2023
77f1aaa
Update specification/trace/semantic_conventions/instrumentation/aws-l…
jdoherty May 23, 2023
bb6ce58
Merge branch 'main' into main
jsuereth May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ release.

## Unreleased

- Updated AWS Java Lambda guidance - using system properties.

### Semantic Conventions

- Clarify the scope of the HTTP client span.
Expand Down
3 changes: 3 additions & 0 deletions specification/trace/semantic_conventions/instrumentation/aws-lambda.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ contain an incomplete trace context which indicates X-Ray isn’t enabled. The e
`Context` will be valid and sampled only if AWS X-Ray has been enabled for the Lambda function. A user can
disable AWS X-Ray for the function if the X-Ray Span Link is not desired.

**Note**: When instrumenting a Java AWS Lambda, instrumentation SHOULD first try to parse an OpenTelemetry `Context` out of the system property `com.amazonaws.xray.traceHeader` using the [AWS X-Ray Propagator](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md) before checking and attempting to parse the environment variable above.
As above, if the resulting `Context` is valid then a Span Link SHOULD be added to the new Spans start options.
jdoherty marked this conversation as resolved.
Show resolved Hide resolved

[Span Link]: https://opentelemetry.io/docs/concepts/signals/traces/#span-links

## API Gateway
Expand Down