Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Fix doc page titles and add Hugo front matter #175

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 7, 2023

/cc @svrnm @cartermp @jsuereth @joaopgrassi

@chalin chalin requested a review from a team July 7, 2023 10:22
@chalin chalin requested a review from a team July 7, 2023 10:22
@chalin chalin changed the title Fix titles and add Hugo front matter [editorial] Fix doc page titles and add Hugo front matter Jul 7, 2023
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this work!

I have a meta-question related to how we keep this hugo matter up to date, given the pace at which we've been adding docs.

TL;DR; we either need a guide on how/what to fill out and when or for some of this can we move it into the docs adjust-pages.pl script?

docs/README.md Show resolved Hide resolved
docs/faas/faas-metrics.md Show resolved Hide resolved
@chalin
Copy link
Contributor Author

chalin commented Jul 7, 2023

@jsuereth - you make good points about some of the front matter. To answer your questions:

  • One of my goals is to eliminate the adjust-pages.pl script, and replace it by a very simple and generic Gulp task that only activates the front matter and little else.
  • I agree that embedding the path_base_for_github_subdir isn't ideal. Yes, that could be handled by the Gulp task.

Would it be ok for this PR to land, and we address your concerns (regarding path_base_for_github_subdir etc) iteratively?

@chalin chalin force-pushed the chalin-im-fix-titles-2023-07-07 branch from 3f7edac to 29ea735 Compare July 7, 2023 15:18
@chalin
Copy link
Contributor Author

chalin commented Jul 7, 2023

I've rebased and re-normalized the new and updated doc pages.

@jsuereth
Copy link
Contributor

jsuereth commented Jul 7, 2023

@chalin

Would it be ok for this PR to land, and we address your concerns (regarding path_base_for_github_subdir etc) iteratively?

Yes, depending on the answer to this question:

If we add new markdown files that do NOT include appropriate hugo frontmatter/github redirect, does it fundamentally break the website?

If the answer is YES, I think we should add a CONTRIBUTING.md section requiring hugo front matter of linkTitle.

@chalin
Copy link
Contributor Author

chalin commented Jul 7, 2023

@jsuereth - no, not having front matter for new files will not break the website build, and the page will get published. The linkTitle field is mainly to define a shorter title name that gets used in the left-side nav and breadcrumbs -- so it's a "nice to have". For example, with the link titles added by this PR, the left sidenav now looks like the same as the list of pages shown in the docs landing page. It's nice to have that correspondence.

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for all the fixes, this looks good to go.

@reyang reyang merged commit eda37d8 into open-telemetry:main Jul 7, 2023
8 checks passed
@chalin chalin deleted the chalin-im-fix-titles-2023-07-07 branch July 10, 2023 13:52
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent page title form and capitalization
4 participants