Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path of md table generation make task #173

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix path of md table generation make task #173

merged 1 commit into from
Jul 7, 2023

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented Jul 7, 2023 •
edited
Loading

Current PRs will not spot table generation issues because the make task still points to /specification.

@joaopgrassi joaopgrassi requested review from a team July 7, 2023 07:28
ChrsMark
ChrsMark approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

jsuereth
jsuereth approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I was sure we were missing more of these locations, just couldn't remember where.

Oberon00
Oberon00 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider merging quickly as otherwise table mistakes may be introduced

@Oberon00 Oberon00 added bug Something isn't working tooling Regarding build, workflows, build-tools, ... labels Jul 7, 2023
@jsuereth jsuereth merged commit fa9dfd3 into open-telemetry:main Jul 7, 2023
9 checks passed
@jsuereth
Copy link
Contributor

jsuereth commented Jul 7, 2023

Was just waiting for second approval

@arminru arminru deleted the fix-md-table-make-task branch July 7, 2023 12:33
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
@joaopgrassi @rapphil
Fix path of md table generation make task (open-telemetry#173)
053fe9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@jsuereth jsuereth

Labels
bug Something isn't working tooling Regarding build, workflows, build-tools, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joaopgrassi @jsuereth @Oberon00 @ChrsMark