Add common attributes to gen-ai spans: server.address, server.port and error.type
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
approved these changes
Jul 30, 2024
lmolkova
changed the title
server.address, server.port and error.typeserver.address, server.port and error.type
trisch-me
reviewed
Jul 30, 2024
nirga
approved these changes
Jul 30, 2024
trisch-me
approved these changes
Jul 30, 2024
maryliag
pushed a commit
to maryliag/semantic-conventions
that referenced
this pull request
Jul 30, 2024
…` and `error.type` (open-telemetry#1297)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common attributes were added on metrics, but we forgot to add them on spans.
Implements general attributes from #810
Merge requirement checklist
[chore]