Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metric jvm.buffer.memory.usage to jvm.buffer.memory.used #1265

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Rename metric jvm.buffer.memory.usage to jvm.buffer.memory.used #1265

merged 5 commits into from
Jul 29, 2024

Conversation

lenin-jaganathan
Copy link
Contributor

@lenin-jaganathan lenin-jaganathan commented Jul 19, 2024 •
edited
Loading

Fixes #288

Changes

  • Rename metric jvm.buffer.memory.usage to jvm.buffer.memory.used

Merge requirement checklist

@lenin-jaganathan lenin-jaganathan requested review from a team July 19, 2024 18:42
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 19, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@lenin-jaganathan lenin-jaganathan force-pushed the jvm_memory-buffer_metric_renaming branch 2 times, most recently from 29efcaf to 15fabe1 Compare July 19, 2024 18:58
@lenin-jaganathan lenin-jaganathan mentioned this pull request Jul 19, 2024
Closed
trask
trask approved these changes Jul 22, 2024
View reviewed changes
.chloggen/jvm_memory-buffer_metric_renaming.yaml Outdated Show resolved Hide resolved
lenin-jaganathan and others added 3 commits July 24, 2024 05:09
@lenin-jaganathan
Rename metric `jvm.buffer.memory.usage
687c4d2 
` to `jvm.buffer.memory.used`

Signed-off-by: Lenin Jaganathan<lenin.jaganathan@gmail.com>
@lenin-jaganathan @trask
Update .chloggen/jvm_memory-buffer_metric_renaming.yaml
0344709 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@lenin-jaganathan
Add deprecated metric info
f27ad24
@lenin-jaganathan lenin-jaganathan force-pushed the jvm_memory-buffer_metric_renaming branch from 6ed26f5 to f27ad24 Compare July 24, 2024 12:10
lmolkova
lmolkova approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

model/metrics/deprecated/jvm-metrics-experimental.yaml Outdated Show resolved Hide resolved
@joaopgrassi
Copy link
Member

What above the other metrics discussed in the issue?

jvm.memory.usage_after_last_gc
jvm.buffer.memory.usage

Are those also suppose to change to used?

@lenin-jaganathan
Copy link
Contributor Author

They were already addressed as part of #536

@joaopgrassi joaopgrassi merged commit 2ac36a5 into open-telemetry:main Jul 29, 2024
12 checks passed
maryliag pushed a commit to maryliag/semantic-conventions that referenced this pull request Jul 30, 2024
@lenin-jaganathan @trask
@joaopgrassi @maryliag
Rename metric jvm.buffer.memory.usage to jvm.buffer.memory.used (o…
cb4948c 
…pen-telemetry#1265)

Signed-off-by: Lenin Jaganathan<lenin.jaganathan@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@trask trask trask approved these changes

@trisch-me trisch-me trisch-me approved these changes

Assignees

@AlexanderWert AlexanderWert

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use consistent suffix for JVM Metrics
6 participants
@lenin-jaganathan @joaopgrassi @trask @lmolkova @trisch-me @AlexanderWert