Update kafka spring example to align with the spec #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
messaging-kafka-spring-example
branch
from
92e5858
to
500574e
Compare
lmolkova
force-pushed
the
messaging-kafka-spring-example
branch
from
f0e7bd4
to
d9a4068
Compare
joaopgrassi
reviewed
Jun 14, 2024
lmolkova
force-pushed
the
messaging-kafka-spring-example
branch
from
349ffd8
to
680afd4
Compare
pyohannes
reviewed
Jun 20, 2024
lmolkova
force-pushed
the
messaging-kafka-spring-example
branch
from
9eb82ac
to
e8ea1fb
Compare
pyohannes
approved these changes
Jun 21, 2024
joaopgrassi
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kafka Spring example does not align with the general messaging spec
see open-telemetry/opentelemetry-dotnet-contrib#1493 (comment)
This PR updates it to:
Merge requirement checklist
[chore]