StableOtlpHTTPExporter implementation #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jhoongo
force-pushed
the
stable-otlp-http-eporter
branch
from
e408154
to
2694baa
Compare
jhoongo
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
bryce-b
reviewed
Oct 18, 2023
| @@ -97,14 +97,15 @@ public enum MetricsAdapter { | |||
| protoDataPoint.value = .asInt(Int64(gaugeData.value)) | |||
| protoMetric.gauge.dataPoints.append(protoDataPoint) | |||
| case .LongSum: | |||
| guard let gaugeData = $0 as? LongPointData else { | |||
| guard let gaugeData = $0 as? LongPointData else { | |||
There was a problem hiding this comment.
white-space is off: should be 2 spaces indentation.
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
jhoongo
force-pushed
the
stable-otlp-http-eporter
branch
3 times, most recently
from
120225e
to
163643d
Compare
jhoongo
force-pushed
the
stable-otlp-http-eporter
branch
from
163643d
to
3919cb0
Compare
bryce-b
approved these changes
Oct 25, 2023
nachoBonafonte
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
Current state of
OpenTelemetry-Swiftlacks an ability to HTTP Exporter forStableMetricand few ability to setaggregationTemporalityfor metrics andmonotonictype.This PR implements
StableOtlpHTTPMetricExporterto implement the missing capabilities.Implementation Details
StableOtlpHTTPExporterBaseandStableOtlpHTTPMetricExporterStableMetricDatato haveisMonotonicandaggregationTemporalityMetricsAdapterto readisMonotonicandaggregationTemporalityfrom it, and prepare the proper request payload for the metrics in protobufOtlpConfigurationfor each request