Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe association between Sampler and TracerProvider. #932

Merged
merged 6 commits into from
Sep 11, 2020
Merged

Describe association between Sampler and TracerProvider. #932

merged 6 commits into from
Sep 11, 2020

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Sep 9, 2020 •
edited
Loading

Fixes #781.

Note that how span and trace IDs are (not) to be generated is currently unspecified, see #864

Changes

  • Describes association of Sampler with TracerProvider. This is hopefully how everyone already implemented this.

@Oberon00 Oberon00 requested review from a team September 9, 2020 11:53
@Oberon00 Oberon00 added area:sampling Related to trace sampling area:sdk Related to the SDK priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Sep 9, 2020
@Oberon00 Oberon00 mentioned this pull request Sep 9, 2020
Open
@carlosalberto
Copy link
Contributor

cc @bogdandrutu (as in Java we store this in a TraceConfig object that belongs to TracerProvider ;) )

@bogdandrutu
Copy link
Member

Yes, but in Java the config is per TP so matches this.

@carlosalberto
Copy link
Contributor

This looks ready to merge. Please update @Oberon00

@Oberon00 Oberon00 mentioned this pull request Sep 11, 2020
Merged
@carlosalberto carlosalberto merged commit 2ba84fe into open-telemetry:master Sep 11, 2020
@Oberon00 Oberon00 deleted the tracerprovider-sampler branch December 18, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@arminru arminru arminru approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:sampling Related to trace sampling area:sdk Related to the SDK priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec needs to mention that a Sampler is associated with a TracerProvider
4 participants
@Oberon00 @carlosalberto @bogdandrutu @arminru