Remove Span.Status per OTEP-134 #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
force-pushed
the
remove-status
branch
from
1028156
to
b2657f1
Compare
Oberon00
reviewed
Sep 3, 2020
| @@ -371,8 +363,8 @@ Links SHOULD preserve the order in which they're set. | |||
|
|
|||
| ### Span operations | |||
|
|
|||
| With the exception of the function to retrieve the `Span`'s `SpanContext` and | |||
| recording status, none of the below may be called after the `Span` is finished. | |||
There was a problem hiding this comment.
Note: This is wrong even in the current spec before removing status.
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
arminru
reviewed
Sep 3, 2020
| @@ -35,7 +35,6 @@ status of the feature is not known. | |||
| |End | + | + | + | + | + | + | + | + | | + | | |||
| |End with timestamp | + | + | + | + | + | + | + | - | | + | | |||
| |IsRecording | + | + | + | + | + | + | + | | | + | | |||
| |Set status | + | + | + | + | + | + | + | + | | + | | |||
There was a problem hiding this comment.
We could keep this and add something like (REMOVED) to keep track of its removal process (until all SIGs are done).
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
MikeGoldsmith
approved these changes
Sep 4, 2020
anuraaga
approved these changes
Sep 4, 2020
Oberon00
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Approving in the sense of "I (and Dynatrace) would be OK with this solution" (even without replacement, as http.status_code et al is enough for us).
Replacing status with unspecified/ok/error would also be fine with me (we would probably still not use it at Dynatrace though as we prefer more specific error information).
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed in favor of open-telemetry/oteps#136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #706
Changes
Remove
Span.Statusas per OTEP-134