Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cloning of ReadWriteLogRecord #4090

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Allow cloning of ReadWriteLogRecord #4090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cd28f5e
Allow adding Clone method to ReadWriteLogRecord
pellared Jun 28, 2024
6d00b95
Update CHANGELOG.md
pellared Jun 28, 2024
50ea836
Update specification/logs/sdk.md
pellared Jun 28, 2024
34e53ea
Update CHANGELOG.md
pellared Jun 28, 2024
73bb86a
Update specification/logs/sdk.md
pellared Jul 18, 2024
c77d7e8
Merge branch 'main' into log-clone
pellared Jul 18, 2024
132bf81
Merge branch 'main' into log-clone
pellared Jul 25, 2024
b80e89d
Merge branch 'main' into log-clone
pellared Jul 25, 2024
c898c54
Describe when deep cloning may be useful
pellared Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ release.

### Logs

- The SDK MAY provide an operation that makes a deep clone of a `ReadWriteLogRecord`.
([#4090](https://github.com/open-telemetry/opentelemetry-specification/pull/4090))

### Events

### Resource
Expand Down
6 changes: 6 additions & 0 deletions specification/logs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,12 @@ the following information added to the [LogRecord](data-model.md#log-and-event-r
* [`SpanId`](./data-model.md#field-spanid)
* [`TraceFlags`](./data-model.md#field-traceflags)

The SDK MAY provide an operation that makes a deep clone of a `ReadWriteLogRecord`.
The operation can be used to implement the [isolating processor](#isolating-processor)
or by asynchronous processors (e.g. [Batching processor](#batching-processor))
to avoid race conditions on the log record that is not required to be
concurrent safe.

## LogRecord Limits

`LogRecord` attributes MUST adhere to
Expand Down
Loading