Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish document content #3955

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Polish document content #3955

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1414a3
Remove an extra letter in tracestate-probability-sampling.md
steverao Mar 22, 2024
cef0b6e
Update specification/trace/tracestate-probability-sampling.md
steverao Mar 22, 2024
23099a3
Polish the docs
steverao Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/trace/tracestate-probability-sampling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ incomplete if the span's parent span was not collected.
Incomplete traces that result from sampling configuration (i.e., on
purpose) are known as partial traces. An important subset of the
partial traces are those which are also complete subtraces. A
complete subtrace is defined at span S when every descendent span is
complete subtrace is defined at a span when every descendant span is
collected.

Since the test for an incompleteness is one-way, it is important to
Expand Down Expand Up @@ -820,7 +820,7 @@ tracestate, we have the following cases:
3. If `TraceIDRatioBased` changes the sampling decision from yes to
no, the consumer will observe singleton trace with correct adjusted
count. The consumer cannot determine that R has two unsampled
descendents.
descendants.

As these cases demonstrate, users can expect incompleteness and
unknown adjusted count when using `TraceIDRatioBased` samplers for
Expand Down
Loading