Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resource field type in Logs Data Model #3826

Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 16, 2024

Changes

Change the type of Resource to reference the definition in the SDK so that the resource's scheme URL is included in logs data model.

Why

The Logs Data Model misses scheme URL of resource. All of the languages reuse a common type representing resource.

These changes can be seen as breaking. However, there is 100% precedence of how log attributes and resource are currently handled in all languages. I see the current description as a bug because we would miss scheme URL of the resource. AFAIK the intention of the OTel Logs Specification authors was to have only nested values for Body and Attributes.

Related PRs:

@pellared pellared marked this pull request as ready for review January 16, 2024 11:24
@pellared pellared requested review from a team January 16, 2024 11:24
@tigrannajaryan
Copy link
Member

This has been open for 2 days, has enough approvals, merging.

@tigrannajaryan tigrannajaryan merged commit 074466b into open-telemetry:main Jan 18, 2024
8 checks passed
@pellared pellared deleted the log-brdige-fix-resource-type branch January 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants