Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align definition of Baggage with W3C Baggage Specification #3800

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Align definition of Baggage with W3C Baggage Specification #3800

merged 2 commits into from
Dec 27, 2023

Conversation

yurishkuro
Copy link
Member

Changes

  • Align Baggage definition with W3C Baggage Specification, namely that it is a container of application-defined properties and that its use is not restricted to "annotating telemetry" as currently stated in the spec. In practice, since Baggage API provides read/write access to baggage, the usage cannot be restricted to observability function anyway, so this is not a breaking change.
  • Also note the distinction from W3C about key uniqueness requirement (OTel being more restrictive).

@yurishkuro
Align definition of Baggage with W3C Baggage Specification
1d99d3a 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested review from a team December 21, 2023 15:53
@yurishkuro
changelog
352b23b 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@reyang reyang merged commit 0127b1f into open-telemetry:main Dec 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@reyang reyang reyang approved these changes

Assignees

@jack-berg jack-berg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurishkuro @carlosalberto @reyang @jack-berg