add optional otel_scope_info configuration for prometheus exporter #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some more options that are exposed in the OTel Go SDK, but not specified in the prometheus exporter details. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/without-scope-info
branch
from
3876117
to
4d5d7ed
Compare
jack-berg
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Programmatic support for this is being added to opentelemetry-java in open-telemetry/opentelemetry-java#6015
|
Note this requirement is captured in the prom compatibility doc https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#instrumentation-scope-1 |
|
cc @dashpole |
carlosalberto
approved these changes
Dec 18, 2023
MrAlias
approved these changes
Dec 19, 2023
|
cc @dashpole |
reyang
approved these changes
Dec 19, 2023
codeboten
pushed a commit
to codeboten/opentelemetry-configuration
that referenced
this pull request
Dec 19, 2023
This follows the spec change: open-telemetry/opentelemetry-specification#3796 Signed-off-by: Alex Boten <aboten@lightstep.com>
jack-berg
pushed a commit
to open-telemetry/opentelemetry-configuration
that referenced
this pull request
Dec 20, 2023
This follows the spec change: open-telemetry/opentelemetry-specification#3796 Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding some more options that are exposed in the OTel Go SDK, but not specified in the prometheus exporter details.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary