Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the MetricProducer #3685

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Stabilize the MetricProducer #3685

merged 6 commits into from
Sep 12, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 8, 2023

Resolve #3599

  • Stabilize the feature-freeze MetricProducer
  • Add a comment on when the SDK needs to be prioritized over the MetricProducer.

@MrAlias
Stabilize the MetricProducer
3c0efef 
Resolve open-telemetry#3599

Add a comment on when the SDK needs to be prioritized over the
MetricProducer.
@MrAlias MrAlias added the spec:metrics Related to the specification/metrics directory label Sep 8, 2023
@MrAlias MrAlias marked this pull request as ready for review September 8, 2023 15:40
@MrAlias MrAlias requested review from a team September 8, 2023 15:40
@MrAlias @jack-berg
Update specification/metrics/sdk.md
9861647 
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
@reyang reyang merged commit e972a26 into open-telemetry:main Sep 12, 2023
7 checks passed
@carlosalberto
Copy link
Contributor

@MrAlias @reyang Should this be part of 1.25.0? (which is the September release) cc @open-telemetry/specs-metrics-approvers

@MrAlias MrAlias deleted the stabilize-metric-producer branch September 12, 2023 18:54
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 12, 2023

@MrAlias @reyang Should this be part of 1.25.0? (which is the September release) cc @open-telemetry/specs-metrics-approvers

That sounds ideal to me.

@reyang
Copy link
Member

reyang commented Sep 13, 2023

@MrAlias @reyang Should this be part of 1.25.0? (which is the September release) cc @open-telemetry/specs-metrics-approvers

That sounds ideal to me.

+1

@jack-berg jack-berg mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@jmacd jmacd

Labels
spec:metrics Related to the specification/metrics directory
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize the MetricProducer
6 participants
@MrAlias @carlosalberto @reyang @pellared @jack-berg @jmacd