Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MetricProducer, and OpenCensus bridges wrap existing interfaces instead of using MetricProducer #3635

Closed
wants to merge 1 commit into from

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Aug 1, 2023

Closes #3599

Changes

Instead of graduating MetricProducer, we could remove it, and attempt to work around its absence. This proposes "wrapping" push exporters and metric reader.

This is loosely based on a prototype in Go: open-telemetry/opentelemetry-go#4378

Pros:

  • No new API or SDK interfaces to achieve roughly the same behavior.

Cons:

  • Two interface implementations required to build a bridge. At least they can share most of the logic.
  • MetricReader and pull metric exporters are very loosely specified. I'm not sure this will work across languages.
  • In Go, it required changes to the Prometheus exporter to allow it to accept a Reader to make this work. This would allow users to change the aggregation temporality of metrics sent to the prometheus exporter.

@dashpole
Copy link
Contributor Author

dashpole commented Aug 1, 2023

Closing based on #3599 (comment)

@dashpole dashpole closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize the MetricProducer
1 participant