Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine SDK MeterProvider configuration section #3522

Merged
merged 11 commits into from
Jun 14, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented May 31, 2023

Towards open-telemetry/opentelemetry-go#3642 (comment)

Changes

  • Create a MeterProvider - Configuration section.
  • Change "managed solely" to "owned". E.g. I do not think it is wrong that one would pass the same reader to a different metrics provider. But the provider has the permission to e.g. shutdown the reader during metrics provider shutdown.
  • Remove "The SDK MUST provide a way to configure all options that are implemented by the SDK." as I do not see any value in this sentence. For me (maybe wrongly) it means like "the configuration MUST by applied".

@pellared pellared marked this pull request as ready for review May 31, 2023 17:56
@pellared pellared requested review from a team May 31, 2023 17:56
@reyang
Copy link
Member

reyang commented May 31, 2023

The tracing spec has something like this https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#tracer-creation. We should consider consistency (might be better to change both).

@pellared
Copy link
Member Author

pellared commented May 31, 2023

The tracing spec has something like this https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#tracer-creation. We should consider consistency (might be better to change both).

I created an issue (feel free to assign it me)

I want to make this PR easier (baby steps).

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw you created an issue for applying this change to tracing. Can you also create an issue to track making this same change to the log SDK?

@pellared
Copy link
Member Author

pellared commented Jun 1, 2023

Saw you created an issue for applying this change to tracing. Can you also create an issue to track making this same change to the log SDK?

Issue created #3527

@pellared
Copy link
Member Author

pellared commented Jun 8, 2023

Please consider merging the PR 😉

@jack-berg
Copy link
Member

@pellared can you add a changelog entry?

@pellared
Copy link
Member Author

@pellared can you add a changelog entry?

What do you want me to write there?

- Refine SDK MeterProvider configuration section. (#3522)

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants