Clarify "Emit a LogRecord" API #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discussed in Log SIG today and the current was unclear since it could be interpreted as API taking LogRecord as an input. This is not the case. The effect of making this API call is to emit a LogRecord to the pipeline, but the API does not take a LogRecord as an input. The input parameters are described in a subsequent paragraph.
reyang
reviewed
Apr 12, 2023
jack-berg
approved these changes
Apr 12, 2023
martinkuba
approved these changes
Apr 12, 2023
reyang
approved these changes
Apr 12, 2023
4 tasks
|
@open-telemetry/specs-logs-approvers please review. |
25 tasks
jsuereth
approved these changes
Apr 18, 2023
lmolkova
pushed a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Apr 20, 2023
We discussed in Log SIG today and the current was unclear since it could be interpreted as API taking LogRecord as an input. This is not the case. The effect of making this API call is to emit a LogRecord to the pipeline, but the API does not take a LogRecord as an input. The input parameters are described in a subsequent paragraph.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed in Log SIG today and the current was unclear since it could be interpreted as API taking LogRecord as an input. This is not the case. The effect of making this API call is to emit a LogRecord to the pipeline, but the API does not take a LogRecord as an input. The input parameters are described in a subsequent paragraph.