Add recommendation to use non-prefixed units for metric instruments #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
area:semantic-conventions
arminru
reviewed
Mar 14, 2023
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
jack-berg
reviewed
Mar 17, 2023
trask
approved these changes
Mar 29, 2023
|
cc @open-telemetry/java-instrumentation-approvers, this will impact |
jmacd
approved these changes
Apr 3, 2023
mateuszrzeszutek
approved these changes
Apr 4, 2023
jack-berg
reviewed
Apr 4, 2023
There was a problem hiding this comment.
This appears to codify the TC vote here. If I properly understood the TC's decision, we recommended going further than only using seconds as the default unit for duration, extending the recommendation to prefer base (or non-prefixed) units generally.
cc @open-telemetry/technical-committee please confirm / revise my understanding of the decision.
jack-berg
reviewed
Apr 4, 2023
jack-berg
reviewed
Apr 4, 2023
reyang
approved these changes
Apr 4, 2023
trask
reviewed
Apr 12, 2023
jack-berg
approved these changes
Apr 12, 2023
|
@open-telemetry/technical-committee I think this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #705 (comment)
Changes
Provides guidelines for when to use a prefixed unit and when to not.
Related issues #705