Add unit to Instrument selection criteria #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
approved these changes
Feb 7, 2023
|
@asafm please sign the CLA so these changes can be considered for merging. |
reyang
approved these changes
Feb 8, 2023
jsuereth
approved these changes
Feb 9, 2023
|
@reyang Added line to changelog - I linked the PR, wasn't sure if I'm suppose to link the PR or the issue |
|
@asafm The CLA check is missing. Could you add that ? |
Working my company to get them to sign and add me |
arminru
added
spec:metrics
jack-berg
approved these changes
Feb 14, 2023
|
@cijothomas CLA approved |
cijothomas
reviewed
Feb 16, 2023
cijothomas
approved these changes
Feb 16, 2023
carlosalberto
approved these changes
Feb 17, 2023
|
cc @jmacd |
bogdandrutu
approved these changes
Feb 21, 2023
|
Please rebase @asafm |
|
@bogdandrutu done |
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added unit criteria to the instrument selection criteria of a view.
Please provide a brief description of the changes here.
For non-trivial changes, follow the change proposal process and link to the related issue(s) and/or OTEP(s), update the
CHANGELOG.md, and also be sure to updatespec-compliance-matrix.mdif necessary.Related issues
Fixes #3101
Related OTEP(s)
none