Add Connect RPC to semantic conventions #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2023
joshcarp
added a commit
to connectrpc/otelconnect-go
that referenced
this pull request
Jan 20, 2023
Conforms to open-telemetry/opentelemetry-specification#3116 Namely: - `buf_connect` is not `connect_rpc` - `status_code` is now `error_code` for `connect_rpc` instances. This means that no attribute is set for success - introduce string consts for grpc, grpcweb connect_rpc...
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
arminru
added
area:semantic-conventions
|
@yurishkuro Would you mind taking a look at this? We've changed the RPC protocol name as you suggested in #2950 and added the relevant docs. |
arminru
reviewed
Feb 8, 2023
arminru
approved these changes
Feb 21, 2023
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
* Add connect_rpc to rpc.yaml * Add connect rpc into rpc-metrics and rpc markdown * Add Connect RPC change to CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
akshayjshah
pushed a commit
to connectrpc/otelconnect-go
that referenced
this pull request
Jul 26, 2023
Conforms to open-telemetry/opentelemetry-specification#3116 Namely: - `buf_connect` is not `connect_rpc` - `status_code` is now `error_code` for `connect_rpc` instances. This means that no attribute is set for success - introduce string consts for grpc, grpcweb connect_rpc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Second attempt, this time a lot more detailed. Original PR is here
The protocol key chosen for the Connect protocol is
connect_rpcasconnectis too general and confusing. Original comment hereBackground
Connect is an RPC protocol that is based on gRPC and it aims to improve on some pitfalls to the gRPC protocol. For the purposes of this PR the main notable differences are:
rpc.grpc.status_codeattribute key, whereas Connect usesrpc.connect_rpc.error_codeattribute key.rpc.yamllooks particularly duplicated, but AFAIK there is no way of creating a table element with keys and no description/values.The stuff that is the same as gRPC, except for
grpc->connect_rpcare:rpc.connect_rpc.<request/response>.metadata.<key>)TODO: Update CHANGELOG.mdCloses: #2949