Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zipkin remoteEndpoint preferences #3087

Merged
merged 13 commits into from
Feb 9, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 9, 2023

Do not reference semantic conventions that have been removed.

Do not reference semantic conventions that have been removed.
@MrAlias MrAlias added the spec:trace Related to the specification/trace directory label Jan 9, 2023
@MrAlias MrAlias requested review from a team January 9, 2023 20:28
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update

<td>Attributes["net.peer.ip"]</td>

and

<td>Attributes["net.peer.name"]</td>

for consistency?

@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 18, 2023

Can you also update

<td>Attributes["net.peer.ip"]</td>

and

<td>Attributes["net.peer.name"]</td>

for consistency?

I would rather scope this PR to updating the Zipkin remote endpoint preferences. Maybe that is a good change for another PR?

@pellared
Copy link
Member

I would rather scope this PR to updating the Zipkin remote endpoint preferences.

I am fine with this.

Maybe that is a good change for another PR?

Let me know if you want to do it or I should create it.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 18, 2023

Let me know if you want to do it or I should create it.

Yeah, please create one. Thanks!

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 27, 2023
@pellared
Copy link
Member

@lmolkova PTAL

@MrAlias MrAlias removed the Stale label Jan 27, 2023
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlosalberto
Copy link
Contributor

@pellared Is your changes request still valid?

@pellared
Copy link
Member

@pellared Is your changes request still valid?

Comments addressed. Approved 👍

@carlosalberto
Copy link
Contributor

cc @yurishkuro

@yurishkuro
Copy link
Member

tbh, I don't understand how to read that table. It gives OTEL names and OTEL definitions - how does that help in translating to Zipkin format? I would've expected either the equivalent Zipkin tag or the dedicated field in Zipkin data model.

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 7, 2023

tbh, I don't understand how to read that table. It gives OTEL names and OTEL definitions - how does that help in translating to Zipkin format? I would've expected either the equivalent Zipkin tag or the dedicated field in Zipkin data model.

The table is an ordered ranking. This PR does not introduce or advocate for the table, it only updates semantic conventions. The table currently contains semantic conventions that were removed. This removes the stale values and replaces them with the replacement semantic conventions. It is an editorial change.

cc @carlosalberto

@carlosalberto
Copy link
Contributor

This looks good to go - will merge right after 1.18.0 is released, in case there's any follow up (by Yuri or anybody that knows Zipkin better than us).

@carlosalberto carlosalberto merged commit fa19ac9 into open-telemetry:main Feb 9, 2023
@MrAlias MrAlias deleted the zipkin-endpoint-pref branch February 9, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants