correct exporter user-agent example #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this section about a User-Agent references RFC7231[1] for format, the example provided includes spaces in the product identifier. The product identifier comes in the form of a token, defined in RFC7230[2]. Including spaces will throw off most existing user-agent parsing. [1] https://datatracker.ietf.org/doc/html/rfc7231#section-5.5.3 [2] https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.6
arminru
added
spec:protocol
|
Thank you! Please also add an entry in |
arminru
approved these changes
Dec 21, 2022
|
cc @codeboten |
codeboten
approved these changes
Dec 21, 2022
MrAlias
approved these changes
Dec 21, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
I am unclear on what change I should make: remove the changelog entry or move it to a different section? If a different section, which section? OpenTelemetry Protocol because this is about OTLP exporters? |
|
@robbkidd Oh, I meant removing the entry from the Changelog basically. On a second though, we want to be explicit to SIGs about updating their user agents, so leets keep keep the entry. |
carlosalberto
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes spaces from the example exporter User-Agent string to conform to header field value component definition.
While this section about a User-Agent references RFC7231 for format, the example provided includes spaces in the
productidentifier. The format forproductis as atoken, defined in RFC7230, which does not include space in the set of valid characters. Including spaces here will throw off most existing user-agent parsing.Related issues: example added in #2684