Rename grpc metadata attribute names to reflect that they are grpc-specific #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
approved these changes
Nov 22, 2022
reyang
added
the
editorial
reyang
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2935
Changes
Makes it clear that
rpc.request.metadata.<key>andrpc.response.metadata.<key>are gRPC-specific, by renaming them torpc.grpc.request.metadata.<key>andrpc.grpc.response.metadata.<key>.Since these are not fixed attribute names, I don't think that schema renames can be added for them? (cc @tigrannajaryan)