Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process.disk.operations metric to semantic conventions #2845

Conversation

andrzej-stencel
Copy link
Member

Fixes #2812

Changes

Adds a new metric process.disk.operations to the semantic conventions.

Context

Here's a related proposal to implement this metric in the OT collector's hostmetrics receiver: open-telemetry/opentelemetry-collector-contrib#14084.

@andrzej-stencel andrzej-stencel marked this pull request as ready for review September 28, 2022 11:19
@andrzej-stencel andrzej-stencel requested review from a team September 28, 2022 11:19
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from f6ba2ae to 5bcb0c7 Compare October 5, 2022 09:11
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 13, 2022
@andrzej-stencel
Copy link
Member Author

What needs to happen for this pull request to be merged? (Other than me updating the branch again)

@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from 5bcb0c7 to f94bda0 Compare October 13, 2022 13:01
@github-actions github-actions bot removed the Stale label Oct 14, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 22, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from f94bda0 to 257228b Compare October 24, 2022 09:30
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from 257228b to 68e1464 Compare October 31, 2022 13:59
@@ -38,6 +38,7 @@ Below is a table of Process metric instruments.
| `process.memory.usage` | UpDownCounter | By | The amount of physical memory in use. | |
| `process.memory.virtual` | UpDownCounter | By | The amount of committed virtual memory. | |
| `process.disk.io` | Counter | By | Disk bytes transferred. | `direction` SHOULD be one of: `read`, `write` |
| `process.disk.operations` | Counter | {operations} | Number of disk operations performed by the process | `direction` SHOULD be one of: `read`, `write` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "control" (e.g. seek, S.M.A.R.T. signal)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is inline with process.disk.io, w/ direction being either read or write. I suspect SMART capabilities would need their own metric(s). I don't how to address seek.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots and back-and-forth, e.g. #2617.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyang I do recognize that this has been a much-discussed topic:

The current state is that metrics very similar to the proposed process.disk.operations metric exist in the semantic conventions in the same shape as the proposed metric (with the "direction" attribute of either "read" or "write"):

This proposal adds the process.disk.operations metric that is related to process.disk.io in the same was that the system.disk.operations is related to system.disk.io metric. I believe this is not a controversial change and there's no reason to not add this metric in the current shape.

If you want the discuss the shape of these metrics, I'd say it's better to open a separate issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not a controversial change and there's no reason to not add this metric in the current shape.

I have different understanding - we already know the existing ones are wrong and will take breaking changes before they can be marked stable, it'll be better to avoid adding more things that require a fix.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from 68e1464 to 6230413 Compare November 7, 2022 11:36
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add process.disk.operations metric
5 participants