add daemon attribute to jvm threads metric #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HaoTu <haotu@alauda.io>
trask
reviewed
Sep 24, 2022
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
…-metrics.md Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
mateuszrzeszutek
approved these changes
Oct 3, 2022
jack-berg
approved these changes
Oct 3, 2022
trask
approved these changes
Oct 3, 2022
reyang
approved these changes
Oct 3, 2022
reyang
reviewed
Oct 3, 2022
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Show resolved
Hide resolved
reyang
approved these changes
Oct 3, 2022
tuhao1020
requested review from
trask and
mateuszrzeszutek
and removed request for
trask and
mateuszrzeszutek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: HaoTu haotu@alauda.io
Fixes #
Changes
add
daemonattribute toprocess.runtime.jvm.threads.countfor example:
related pr: open-telemetry/opentelemetry-java-instrumentation#6635