Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process.paging.faults metric to semantic conventions #2827

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Add process.paging.faults metric to semantic conventions #2827

merged 4 commits into from
Oct 18, 2022

Conversation

andrzej-stencel
Copy link
Member

Fixes #2809

Changes

Adds a new metric process.paging.faults to the semantic conventions.

@andrzej-stencel andrzej-stencel marked this pull request as ready for review September 23, 2022 13:07
@andrzej-stencel andrzej-stencel requested review from a team September 23, 2022 13:07
@joaopgrassi
Copy link
Member

I wonder if we should wait for the build-tools PR to be merged open-telemetry/build-tools#79 so metrics semconv can finally start being auto-generated. If we allow more coming it's just more work on whoever is going to bring them into YAML files.

@andrzej-stencel
Copy link
Member Author

andrzej-stencel commented Sep 30, 2022 •
edited
Loading

I wonder if we should wait for the build-tools PR to be merged open-telemetry/build-tools#79 so metrics semconv can finally start being auto-generated. If we allow more coming it's just more work on whoever is going to bring them into YAML files.

This is valid point. If this PR is very close to being merged (like in less than a week), I believe it's better to wait. If it will take longer to merge the PR, perhaps it's better to unblock the changes to semantic conventions. I'm happy to help with the updates to the YAML files in any case.

@joaopgrassi
Copy link
Member

The build tools PR should be ready to go, just need folks to review it. Hopefully it happens next week.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 13, 2022
@andrzej-stencel
Copy link
Member Author

What needs to happen for this pull request to be merged? (Other than me updating the branch again)

@github-actions github-actions bot removed the Stale label Oct 14, 2022
@jsuereth
Copy link
Contributor

I don't think this needs to wait on the build-tools PR. IF there are enough approvals of this change, then it can go in first.

reyang
reyang approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the area:semantic-conventions Related to semantic conventions label Oct 18, 2022
@reyang reyang merged commit 5edc08b into open-telemetry:main Oct 18, 2022
@andrzej-stencel andrzej-stencel deleted the add-process-paging-faults-metric branch October 19, 2022 10:17
@andrzej-stencel andrzej-stencel mentioned this pull request Nov 8, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@reyang reyang reyang approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add process page fault metrics
5 participants
@andrzej-stencel @joaopgrassi @jsuereth @reyang @yurishkuro