Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #2426

Merged
merged 10 commits into from
Mar 22, 2022
Merged

Fix links #2426

merged 10 commits into from
Mar 22, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Mar 21, 2022

It seems some tooling change caused the CI to fail #2415 (comment). Most likely due to the recent change in markdown-link-check@3.10.0 tcort/markdown-link-check@6522186.

Hopefully this quick workaround would unblock the CI.

Related to tcort/markdown-link-check#193. If the author of markdown-link-check agrees that it's a bug rather than by-design, we might want to simply disable it in the CI for now and wait for the fix, or pin the tool to the last-known-good version.

@reyang reyang requested review from a team March 21, 2022 17:13
@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Mar 21, 2022
@reyang reyang requested a review from a team March 21, 2022 17:22
@reyang reyang requested a review from a team March 21, 2022 17:27
@tigrannajaryan
Copy link
Member

Job still failing, looks like there are a few other dead links.

@tigrannajaryan
Copy link
Member

@reyang can you please update the PR to fix the rest of the links? We are blocked on this, no other PRs can be merged until this is fixed.

@reyang reyang changed the title Fix link Fix links Mar 22, 2022
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants