-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links #2426
Merged
Merged
Fix links #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
added
the
editorial
Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
label
Mar 21, 2022
tigrannajaryan
approved these changes
Mar 21, 2022
Job still failing, looks like there are a few other dead links. |
@reyang can you please update the PR to fix the rest of the links? We are blocked on this, no other PRs can be merged until this is fixed. |
yurishkuro
approved these changes
Mar 22, 2022
jmacd
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
editorial
Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems some tooling change caused the CI to fail #2415 (comment). Most likely due to the recent change in
markdown-link-check@3.10.0
tcort/markdown-link-check@6522186.Hopefully this quick workaround would unblock the CI.
Related to tcort/markdown-link-check#193. If the author of
markdown-link-check
agrees that it's a bug rather than by-design, we might want to simply disable it in the CI for now and wait for the fix, or pin the tool to the last-known-good version.