For prometheus metrics without sums, leave the sum unset #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
approved these changes
Mar 10, 2022
Aneurysm9
approved these changes
Mar 10, 2022
|
I thought we were intending to make the sum field |
|
Thanks for pointing that out, Josh. I wasn't aware of that change, but it makes a lot of sense. I've updated this to say the sum must be unset. |
dashpole
changed the title
jack-berg
approved these changes
Mar 16, 2022
jmacd
approved these changes
Mar 16, 2022
cijothomas
approved these changes
Mar 18, 2022
bogdandrutu
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: open-telemetry/opentelemetry-collector-contrib#7546
Changes
It is not possible to implement the spec as it is currently written, since the sum cannot be computed from buckets.
The OpenMetrics histogram spec says:
We have two options for how to handle histograms without sums:
Leaving it unset is the correct way to handle this case.
cc @Aneurysm9 @jmacd