Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify what does wildcard mean in the Metrics SDK View #2325

Merged
merged 6 commits into from
Feb 11, 2022
Merged

Clarify what does wildcard mean in the Metrics SDK View #2325

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
205f620
Clarify what does wildcard mean in the Metrics SDK View
reyang Feb 8, 2022
948719e
changelog
reyang Feb 8, 2022
15c805f
Update specification/metrics/sdk.md
reyang Feb 8, 2022
2c416dc
feedback
reyang Feb 8, 2022
ecdd3a4
fix url
reyang Feb 8, 2022
6b95143
Merge branch 'main' into reyang/metrics-sdk-wildcard
jmacd Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ release.
[#2032](https://github.com/open-telemetry/opentelemetry-specification/pull/2061)
- Changed default Prometheus Exporter host from `0.0.0.0` to `localhost`.
([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282))
- Clarified wildcard and predicate support in metrics SDK View API.
([#2325])(https://github.com/open-telemetry/opentelemetry-specification/pull/2325))

### Logs

Expand Down
7 changes: 6 additions & 1 deletion specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,12 @@ are the inputs:

* The Instrument selection criteria (required), which covers:
* The `type` of the Instrument(s) (optional).
* The `name` of the Instrument(s), with wildcard support (optional).
* The `name` of the Instrument(s). [OpenTelemetry SDK](../overview.md#sdk)
authors MAY choose to support `name` that contains wildcards, with the
reyang marked this conversation as resolved.
Show resolved Hide resolved
question mark (`?`) matching exactly one character and the asterisk
character (`*`) matching zero or more characters. In addition, the
OpenTelemetry SDK authors MAY choose to support additional predicates that
are idiomatic for their language (e.g. regular expressions, callbacks).
reyang marked this conversation as resolved.
Show resolved Hide resolved
reyang marked this conversation as resolved.
Show resolved Hide resolved
* The `name` of the Meter (optional).
* The `version` of the Meter (optional).
* The `schema_url` of the Meter (optional).
Expand Down